[Tarantool-patches] [PATCH LUAROCKS v2 0/2] Move a rocks options filter from tarantoolctl to luarocks

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Mar 19 01:12:49 MSK 2020


Hi! Thanks for the patchset!

Generally the comments are the same as for the other rocks-related
patchset:

- Add a @ChangeLog;
- Provide a description of the patchset in the cover-letter. What
  was made, how, why?

On 19/11/2019 09:52, Leonid wrote:
> https://github.com/tarantool/tarantool/issues/4629
> https://github.com/tarantool/luarocks/tree/lvasiliev/gh-4629-add-chdir-to-make
> 
> Changes in v2:
> - Move chdir before loading the rockspec file
> 
> Leonid (2):
>   Add the chdir option for make
>   Add the tarantool options black list. Update help
> 
>  src/luarocks/cmd/help.lua | 15 +++++++++------
>  src/luarocks/cmd/make.lua | 22 ++++++++++++++++------
>  src/luarocks/util.lua     | 25 ++++++++++++++++++++-----
>  3 files changed, 45 insertions(+), 17 deletions(-)
> 


More information about the Tarantool-patches mailing list