[Tarantool-patches] [PATCH v2] Add some cancellation guard

[Cyrill Gorcunov]

On Tue, Mar 17, 2020 at 09:49:14PM +0300, Georgy Kirichenko wrote:
...
> > > +
> > > +	/*
> > > +	 * The thread should not be canceled while mutex is locked
> > > +	*/
> > > +	int old_cancel_state;
> > > +	tt_pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancel_state);
> > 
> > Don't we need to disable cancel at the entry of this cpipe_destroy?
> > Thus trigger_destroy would be guarantee to finish, or it is not
> > that important in which moment we disable cancelling?
> > 
> > Other than that the patch looks ok to me, still the overall cbus
> > code looks a bit fishy. Do we really need these threads to be
> > cancellable?
> A relay thread is canceled instead of gracefully exit. Despite relay exits 

Oh my :(

> issue is addressed by my replication-form-memory patch I think this patch is 
> useful.

As I pointed I'm ok with this patch since it address an issue.
Still I don't really like the overall design. But this is a
different story...