[Tarantool-patches] [PATCH v2] build: disable LUAJIT_ENABLE_PAIRSMM

Igor Munkin imun at tarantool.org
Tue Mar 17 01:46:07 MSK 2020


Vlad,

Thanks for your review.

On 16.03.20, Vladislav Shpilevoy wrote:
> > diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.result b/test/box/gh-4770-broken-pairs-for-space-objects.result
> > index 3ac5995c2..c678714ee 100644
> > --- a/test/box/gh-4770-broken-pairs-for-space-objects.result
> > +++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
> > @@ -1,14 +1,7 @@
> >  -- test-run result file version 2
> > -env = require('test_run')
> > +test_run = require('test_run').new()
> 
> Seems like you don't need 'test_run' object either.

Fixed, squashed, force-pushed to the branch. Diff is below:

================================================================================

diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.result b/test/box/gh-4770-broken-pairs-for-space-objects.result
index c678714ee..6ab778d1a 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.result
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
@@ -1,8 +1,4 @@
 -- test-run result file version 2
-test_run = require('test_run').new()
- | ---
- | ...
-
 --
 -- gh-4770: Iteration through space with Lua builtin pairs routine
 --
diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
index a1ba1eeab..8c36bd305 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
@@ -1,5 +1,3 @@
-test_run = require('test_run').new()
-
 --
 -- gh-4770: Iteration through space with Lua builtin pairs routine
 --

================================================================================

> 
> But ok, LGTM.

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list