[Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t

Konstantin Osipov kostja.osipov at gmail.com
Mon Mar 16 23:31:26 MSK 2020


* Serge Petrenko <sergepetrenko at tarantool.org> [20/03/05 14:36]:
> We're using an unsigned int to hold vclock map, but there is no
> guarantee that unsigned int will be 4 bytes in size to fit all the 32
> vclock components. So use uint32_t instead.

I think there is a bunch of functions that still use unsigned to
pass the vclock value around.

Besides, if you work on a fix like that, it's best to use a
typedef right away, so that it's easy to change to uint64t or 128
bit integer in the future.

> No issue, discussed in scope of
> https://github.com/tarantool/tarantool/issues/4739
> Branch: https://github.com/tarantool/tarantool/tree/sp/vclock-map-refactor

-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list