[Tarantool-patches] [PATCH] evio: workaround for wsl1 so_linger assertion

Timur Safin tsafin at tarantool.org
Mon Mar 16 19:04:52 MSK 2020



: -----Original Message-----
: From: Cyrill Gorcunov <gorcunov at gmail.com>
: Sent: Monday, March 16, 2020 6:32 PM
: To: Timur Safin <tsafin at tarantool.org>
: Cc: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>; Cyrill Gorcunov
: <gorcunov at tarantool.org>; tarantool-patches at dev.tarantool.org
: Subject: Re: [Tarantool-patches] [PATCH] evio: workaround for wsl1
: so_linger assertion
: 


: > +
: > +    # There are some subtle differences in Linux kernel calls
: > +    # implementation under WSL1 (which should go away with WSL2 kernel)
: > +    # so for a moment we introduce a way to distinguish Linux and
: > +    # Microsoft/WSL1
: > +    if (${CMAKE_SYSTEM} MATCHES "Linux-.*-Microsoft")
: > +        add_definitions("-DTARANTOOL_WSL_WORKAROUND_ENABLED=1")
: > +    endif()
: > +
: 
: Great! Thanks a huge, Timur! Since you mentioned WSL2 maybe we should
: name it -DTARANTOOL_WSL_1 ? I don't insist though.
: 
: Acked-by: Cyrill Gorcunov <gorcunov at gmail.com>

Agreed, will rename it shortly to *WSL1_WORKAROUND*

Timur



More information about the Tarantool-patches mailing list