[Tarantool-patches] [PATCH v2] build: disable LUAJIT_ENABLE_PAIRSMM

Igor Munkin imun at tarantool.org
Mon Mar 16 13:12:51 MSK 2020


Vlad,

On 12.03.20, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> > --- /dev/null
> > +++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
> > @@ -0,0 +1,41 @@
> > +-- test-run result file version 2
> > +env = require('test_run')
> > + | ---
> > + | ...
> > +test_run = env.new()
> > + | ---
> > + | ...
> > +test_run:cmd("push filter 'table: .*' to 'table: <address>'")
> 
> Why do you need the filter? There is nothing to filter out.
> You never print any 'table: .*' strings.
> 

Thanks for your comment! I overlooked this line when copy-pasting the
preambule from box/misc.test.lua and I agree the filter is excess.

Fixed, squashed, force-pushed to the branch. Diff is below:

================================================================================

diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.result b/test/box/gh-4770-broken-pairs-for-space-objects.result
index 3ac5995c2..c678714ee 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.result
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
@@ -1,14 +1,7 @@
 -- test-run result file version 2
-env = require('test_run')
+test_run = require('test_run').new()
  | ---
  | ...
-test_run = env.new()
- | ---
- | ...
-test_run:cmd("push filter 'table: .*' to 'table: <address>'")
- | ---
- | - true
- | ...
 
 --
 -- gh-4770: Iteration through space with Lua builtin pairs routine
diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
index 315352b15..a1ba1eeab 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
@@ -1,6 +1,4 @@
-env = require('test_run')
-test_run = env.new()
-test_run:cmd("push filter 'table: .*' to 'table: <address>'")
+test_run = require('test_run').new()
 
 --
 -- gh-4770: Iteration through space with Lua builtin pairs routine

================================================================================

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list