[Tarantool-patches] [PATCH 0/7] popen: various fixes and a test

[Cyrill Gorcunov]

On Thu, Mar 12, 2020 at 02:58:42PM +0300, Alexander Turenko wrote:
> I don't have objections anymore. LGTM.
> 
> The actual version is on the branch gorcunov/gh-4031-popen-fixup-5.
> 
> I'm a bit afraid that we don't test POPEN_FLAG_SETSID. However the code
> itself looks right and we maybe will return to this later.
> 
> NB: We'll need to test two things to verify setsid():
> 
> * The situation when a controlling terminal died. Maybe use screen /
>   tmux here?
> * The ability to kill a spawned process group at whole (but w/o
>   tarantool itself). Say, "sh -c 'foo | bar'".
> 
> Pushed also gorcunov/gh-4031-popen-fixup-5-full-ci to verify on all
> targets (just in case). See results here:
> https://gitlab.com/tarantool/tarantool/pipelines/125648893 (they are now
> in fly).

Thanks a huge, Sasha! I think we continue fixing/extending popen engine.