[Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks

Konstantin Osipov kostja.osipov at gmail.com
Sat Mar 7 00:37:43 MSK 2020


* Cyrill Gorcunov <gorcunov at gmail.com> [20/03/05 15:32]:
> The callbacks gonna be different from sync and async
> commits thus lets untangle it from journal_entry_new
> interface but setup explicitly.
> 
> I think setting up NULLs for entry is a safe approach
> so we can allow us to spend a few cycles.

This is a hot path. 

I don't see much value in this patch, but I don't think it
makes much of a difference either way.

My preference is to drop this patch, just pass different
call backs from different call sites.


-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list