[Tarantool-patches] [PATCH v2] iproto: add an empty body to the unprepare response

Nikita Pettik korablev at tarantool.org
Thu Mar 5 11:41:35 MSK 2020


On 05 Mar 08:41, Kirill Yukhin wrote:
> Hello,
> 
> On 03 мар 19:16, Chris Sosnin wrote:
> > Absence of the body in the unprepare response forces users to perform
> > additional checks to avoid errors. Adding an empty body fixes this problem.
> > 
> > Closes #4769
> > ---
> > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4769-unprepare-response-body
> > issue: https://github.com/tarantool/tarantool/issues/4769
> > 
> > As Nikita suggested, I created box/iproto.test.lua, and basically
> > inserted wrappers for requests testing from box-py for future usage.
> 
> Could you please rename the test to be not so generic?
> Like box/gh-4769-iproto-unprep-body or whatever.

Kirill, this test is going to assemble all iproto-related tests
which don't rely on net.box module. Setting up all preparations
required for raw iproto communication results in duplicating ~30-40
lines of code in each test file.
 
> --
> Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list