[Tarantool-patches] [PATCH] replication: fix rebootstrap in case the instance is listed in box.cfg.replication

Kirill Yukhin kyukhin at tarantool.org
Thu Mar 5 07:52:53 MSK 2020


Hello,

On 03 мар 11:25, Kirill Yukhin wrote:
> Hello,
> 
> On 28 фев 20:01, Serge Petrenko wrote:
> > When checking wheter rejoin is needed, replica loops through all the
> > instances in box.cfg.replication, which makes it believe that there is a
> > master holding files, needed by it, since it accounts itself just like
> > all other instances.
> > So make replica skip itself when finding an instance which holds files
> > needed by it, and determining whether rebootstrap is needed.
> > 
> > We already have a working test for the issue, it missed the issue due to
> > replica.lua replication settings. Fix replica.lua to optionally include
> > itself in box.cfg.replication, so that the corresponding test works
> > correctly.
> > 
> > Closes #4759
> > ---
> > https://github.com/tarantool/tarantool/issues/4759
> > https://github.com/tarantool/tarantool/tree/sp/gh-4759-rebootstrap-fix
> 
> THe patch LGTM. I've checked it into 2.2, 2.3 and master.

CHecked into 1.10 as well.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list