[Tarantool-patches] [PATCH v2 luajit 0/3] Introduce gdb extension for LuaJIT

[Alexander Turenko]

I don't think that it worth to do in-depth review from my side. But I
tried the extension, it works and gives output that I can interpret. It
also has the documentation that is available using gdb's built-in help
command. It is nice, thanks, Igor!

So the patchset LGTM. CCed Kirill.

Igor, please, file an issue for the further activity: we should ship the
tool in our packages (possibly tarantool-dev/devel) in paths, where gdb
will able to catch it automatically.

WBR, Alexander Turenko.

On Tue, Mar 03, 2020 at 07:17:12PM +0300, Igor Munkin wrote:
> Sasha,
> 
> I squashed the first patch of the series (gdb: introduce luajit-gdb
> extension) with the third one (gdb: enhance the extension loading) as
> you proposed supra.
> 
> As discussed offline, the second patch is left to separate the changes
> required for compatibility with Python 2 in git repo history.
> 
> Rebased, force-pushed to the branch.
> 
> On 27.02.20, Alexander Turenko wrote:
> > > * the feature port to Python 2 (I hope it can be dropped in some
> > > time)
> > 
> > According to [1] not before June, 2024. However I guess that in fact
> > it may be needed even after 2024.
> > 
> > Not soon.
> > 
> > [1]: https://wiki.centos.org/About/Product
> 
> -- 
> Best regards,
> IM