[Tarantool-patches] [PATCH] sequence: return correct error on using dropped sequence

Chris Sosnin k.sosnin at tarantool.org
Mon Mar 2 18:25:15 MSK 2020


Hi! Thank you for the review!

> 2 марта 2020 г., в 13:59, Nikita Pettik <korablev at tarantool.org> написал(а):
> 
> On 29 Feb 16:43, Vladislav Shpilevoy wrote:
>> LGTM.
>> 
>> On 26/02/2020 17:13, Chris Sosnin wrote:
>>> This code is called from C, so it shouldn't throw.
>>> 
>>> Closes #4753
>>> ---
>>> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4753-sequence-cpp-exception 
>>> issue: https://github.com/tarantool/tarantool/issues/4753
>>> 
> 
> Patch LGTM as well, but I see that 3 out of 4 runs on travis result in fail:
> 
> https://travis-ci.org/tarantool/tarantool/builds/655369924?utm_source=github_status&utm_medium=notification
> 
> Are these known failures (box/access etc)?
> 

I didn’t rebase the patch, I’m sorry.
This branch doesn’t have the fix for Masha’s patch, where credentials for user weren’t dropped at the and of the test.
Will fix it.


More information about the Tarantool-patches mailing list