[Tarantool-patches] [PATCH v2 01/19] replication: introduce space.is_sync option
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Tue Jun 30 02:15:10 MSK 2020
Synchronous space makes every transaction, affecting its data,
wait until it is replicated on a quorum of replicas before it is
committed.
Part of #4844
Part of #5073
---
src/box/alter.cc | 5 ++
src/box/lua/net_box.lua | 2 +
src/box/lua/schema.lua | 3 +
src/box/lua/space.cc | 5 ++
src/box/space_def.c | 2 +
src/box/space_def.h | 6 ++
.../sync_replication_sanity.result | 71 +++++++++++++++++++
.../sync_replication_sanity.test.lua | 29 ++++++++
8 files changed, 123 insertions(+)
create mode 100644 test/replication/sync_replication_sanity.result
create mode 100644 test/replication/sync_replication_sanity.test.lua
diff --git a/src/box/alter.cc b/src/box/alter.cc
index bb4254878..249cee2da 100644
--- a/src/box/alter.cc
+++ b/src/box/alter.cc
@@ -663,6 +663,11 @@ space_def_new_from_tuple(struct tuple *tuple, uint32_t errcode,
diag_set(ClientError, ER_VIEW_MISSING_SQL);
return NULL;
}
+ if (opts.is_sync && opts.group_id == GROUP_LOCAL) {
+ diag_set(ClientError, errcode, tt_cstr(name, name_len),
+ "local space can't be synchronous");
+ return NULL;
+ }
struct space_def *def =
space_def_new(id, uid, exact_field_count, name, name_len,
engine_name, engine_name_len, &opts, fields,
diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua
index 9560bfdd4..34fb25e4a 100644
--- a/src/box/lua/net_box.lua
+++ b/src/box/lua/net_box.lua
@@ -1344,6 +1344,7 @@ function remote_methods:_install_schema(schema_version, spaces, indices,
s.enabled = true
s.index = {}
s.temporary = false
+ s.is_sync = false
s._format = format
s._format_cdata = box.internal.new_tuple_format(format)
s.connection = self
@@ -1352,6 +1353,7 @@ function remote_methods:_install_schema(schema_version, spaces, indices,
if type(opts) == 'table' then
-- Tarantool >= 1.7.0
s.temporary = not not opts.temporary
+ s.is_sync = not not opts.is_sync
elseif type(opts) == 'string' then
-- Tarantool < 1.7.0
s.temporary = string.match(opts, 'temporary') ~= nil
diff --git a/src/box/lua/schema.lua b/src/box/lua/schema.lua
index e6844b45f..2edf25fae 100644
--- a/src/box/lua/schema.lua
+++ b/src/box/lua/schema.lua
@@ -413,6 +413,7 @@ box.schema.space.create = function(name, options)
format = 'table',
is_local = 'boolean',
temporary = 'boolean',
+ is_sync = 'boolean',
}
local options_defaults = {
engine = 'memtx',
@@ -457,6 +458,7 @@ box.schema.space.create = function(name, options)
local space_options = setmap({
group_id = options.is_local and 1 or nil,
temporary = options.temporary and true or nil,
+ is_sync = options.is_sync
})
_space:insert{id, uid, name, options.engine, options.field_count,
space_options, format}
@@ -2704,6 +2706,7 @@ local function box_space_mt(tab)
engine = v.engine,
is_local = v.is_local,
temporary = v.temporary,
+ is_sync = v.is_sync,
}
end
end
diff --git a/src/box/lua/space.cc b/src/box/lua/space.cc
index d0e44dd41..177c58830 100644
--- a/src/box/lua/space.cc
+++ b/src/box/lua/space.cc
@@ -253,6 +253,11 @@ lbox_fillspace(struct lua_State *L, struct space *space, int i)
lua_pushstring(L, space->def->engine_name);
lua_settable(L, i);
+ /* space.is_sync */
+ lua_pushstring(L, "is_sync");
+ lua_pushboolean(L, space->def->opts.is_sync);
+ lua_settable(L, i);
+
lua_pushstring(L, "enabled");
lua_pushboolean(L, space_index(space, 0) != 0);
lua_settable(L, i);
diff --git a/src/box/space_def.c b/src/box/space_def.c
index efb1c8ee9..83566bf02 100644
--- a/src/box/space_def.c
+++ b/src/box/space_def.c
@@ -41,6 +41,7 @@ const struct space_opts space_opts_default = {
/* .is_temporary = */ false,
/* .is_ephemeral = */ false,
/* .view = */ false,
+ /* .is_sync = */ false,
/* .sql = */ NULL,
};
@@ -48,6 +49,7 @@ const struct opt_def space_opts_reg[] = {
OPT_DEF("group_id", OPT_UINT32, struct space_opts, group_id),
OPT_DEF("temporary", OPT_BOOL, struct space_opts, is_temporary),
OPT_DEF("view", OPT_BOOL, struct space_opts, is_view),
+ OPT_DEF("is_sync", OPT_BOOL, struct space_opts, is_sync),
OPT_DEF("sql", OPT_STRPTR, struct space_opts, sql),
OPT_DEF_LEGACY("checks"),
OPT_END,
diff --git a/src/box/space_def.h b/src/box/space_def.h
index 788b601e6..198242d02 100644
--- a/src/box/space_def.h
+++ b/src/box/space_def.h
@@ -67,6 +67,12 @@ struct space_opts {
* this flag can't be changed after space creation.
*/
bool is_view;
+ /**
+ * Synchronous space makes all transactions, affecting its
+ * data, synchronous. That means they are not applied
+ * until replicated to a quorum of replicas.
+ */
+ bool is_sync;
/** SQL statement that produced this space. */
char *sql;
};
diff --git a/test/replication/sync_replication_sanity.result b/test/replication/sync_replication_sanity.result
new file mode 100644
index 000000000..551df7daf
--- /dev/null
+++ b/test/replication/sync_replication_sanity.result
@@ -0,0 +1,71 @@
+-- test-run result file version 2
+--
+-- gh-4282: synchronous replication. It allows to make certain
+-- spaces commit only when their changes are replicated to a
+-- quorum of replicas.
+--
+s1 = box.schema.create_space('test1', {is_sync = true})
+ | ---
+ | ...
+s1.is_sync
+ | ---
+ | - true
+ | ...
+pk = s1:create_index('pk')
+ | ---
+ | ...
+box.begin() s1:insert({1}) s1:insert({2}) box.commit()
+ | ---
+ | ...
+s1:select{}
+ | ---
+ | - - [1]
+ | - [2]
+ | ...
+
+-- Default is async.
+s2 = box.schema.create_space('test2')
+ | ---
+ | ...
+s2.is_sync
+ | ---
+ | - false
+ | ...
+
+-- Net.box takes sync into account.
+box.schema.user.grant('guest', 'super')
+ | ---
+ | ...
+netbox = require('net.box')
+ | ---
+ | ...
+c = netbox.connect(box.cfg.listen)
+ | ---
+ | ...
+c.space.test1.is_sync
+ | ---
+ | - true
+ | ...
+c.space.test2.is_sync
+ | ---
+ | - false
+ | ...
+c:close()
+ | ---
+ | ...
+box.schema.user.revoke('guest', 'super')
+ | ---
+ | ...
+
+s1:drop()
+ | ---
+ | ...
+s2:drop()
+ | ---
+ | ...
+
+-- Local space can't be synchronous.
+box.schema.create_space('test', {is_sync = true, is_local = true})
+ | ---
+ | - error: 'Failed to create space ''test'': local space can''t be synchronous'
+ | ...
diff --git a/test/replication/sync_replication_sanity.test.lua b/test/replication/sync_replication_sanity.test.lua
new file mode 100644
index 000000000..fd7ed537e
--- /dev/null
+++ b/test/replication/sync_replication_sanity.test.lua
@@ -0,0 +1,29 @@
+--
+-- gh-4282: synchronous replication. It allows to make certain
+-- spaces commit only when their changes are replicated to a
+-- quorum of replicas.
+--
+s1 = box.schema.create_space('test1', {is_sync = true})
+s1.is_sync
+pk = s1:create_index('pk')
+box.begin() s1:insert({1}) s1:insert({2}) box.commit()
+s1:select{}
+
+-- Default is async.
+s2 = box.schema.create_space('test2')
+s2.is_sync
+
+-- Net.box takes sync into account.
+box.schema.user.grant('guest', 'super')
+netbox = require('net.box')
+c = netbox.connect(box.cfg.listen)
+c.space.test1.is_sync
+c.space.test2.is_sync
+c:close()
+box.schema.user.revoke('guest', 'super')
+
+s1:drop()
+s2:drop()
+
+-- Local space can't be synchronous.
+box.schema.create_space('test', {is_sync = true, is_local = true})
--
2.21.1 (Apple Git-122.3)
More information about the Tarantool-patches
mailing list