[Tarantool-patches] [PATCH 0/3] log: allow json formatter in boottime logger

Oleg Babin olegrok at tarantool.org
Mon Jun 29 15:50:00 MSK 2020


Hi! Thanks for your patch. Looks good but I want to clarify one thing:


```

tarantool> log.cfg{log = 'syslog', format='json'}
---
...

```

It works fine but seems such command should throw an error:

"json can't be used with syslog logger", isn't it?

It happened because "ffi.C.log_type()" returns "0" -- boot-time logger.


On 29/06/2020 14:23, Cyrill Gorcunov wrote:
> For some reason we've disabled usage of json formatter in early
> logging since the commit 098324556. Lets allow it back.
>
> issue https://github.com/tarantool/tarantool/issues/5121
> branch gorcunov/gh-5121-logger-boot-json
>
> Cyrill Gorcunov (3):
>    core/say: allow to use json in boot logger
>    lua/log: allow to use json formatter early
>    test: app-tap/logger -- test json in boottime logger
>
>   src/lib/core/say.c           | 7 ++-----
>   src/lua/log.lua              | 6 ++----
>   test/app-tap/logger.test.lua | 8 +++++---
>   3 files changed, 9 insertions(+), 12 deletions(-)
>


More information about the Tarantool-patches mailing list