[Tarantool-patches] [PATCH 1/2] box: rework local_recovery to use async txn_commit

[Vladislav Shpilevoy]

On 23/06/2020 10:39, Serge Petrenko wrote:
> 
> 23.06.2020 00:43, Vladislav Shpilevoy пишет:
>> I am looking at the commit which added on_write_failure.
>> Why can't we reuse on_rollback trigger? As we discussed,
>> we can pass whatever we want using txn->signature. So
>> for manual rollback we can set it to -1, for write failure
>> to -2, for limbo rollback to -3, for timeout to -4, etc.
>>
>> I am just afraid that +16 bytes for transaction object
>> may affect performance of the async transactions.
> 
> We can. I've just done it & dropped the additionnal commit
> 
> (the one that hacked the trigger removal in recovery.

We also can drop TXN_IS_ABORTED_BY_YIELD and reuse the signature
for this type of error too.