[Tarantool-patches] [PATCH v2 1/7] build: static build needs more cleanup in sources

Alexander Turenko alexander.turenko at tarantool.org
Fri Jun 26 16:51:06 MSK 2020


> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 253f2d5e9..f67f46f5e 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -75,7 +75,7 @@ RUN set -x && \
>  RUN set -x && \
>      find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \
>      find . -name 'CMakeCache.txt' -type f -delete && \
> -    rm -rf build
> +    rm -rf build test/small test/luajit-tap

What if I'll push a short-term branch that adds one more test directory?

I think that the directory should be cleaned up entirely (git clean for
sources and submodules). And it seems that it is done with [1], right?
Such spotted cleanup will insuperably fails in some cases.

Anyway, I don't have objections against this certain patch if it still
needed after [1], just noted that it necessary only because the overall
approach is not good.

[1]: https://github.com/tarantool/tarantool/issues/5036

WBR, Alexander Turenko.


More information about the Tarantool-patches mailing list