[Tarantool-patches] [PATCH v1 0/4] Fix app/digest and app/socket on 1.10

Alexander Turenko alexander.turenko at tarantool.org
Tue Jun 23 17:08:22 MSK 2020


> commit 6595e9fccfb3f52e9c551458cbe0285d651c812b
> Author: Alexander V. Tikhonov <avtikhon at tarantool.org>
> Date:   Thu Jun 18 01:55:58 2020 +0300
> 
>     Bump libyaml
>     
>     Set to use in libyaml tarantool-1.10 branch with the following
>     bumped commit:
>     
>       f1d1e5e0a5f6e6adeebe0e2c5e95a6ee729426e4 'cmake: make sure yaml is built statically when used in tarantool'

Nit: I would carry the line in the commit message.

Nit: I would use cherry-pick -x for picking commits from libyaml master
for tarantool-1.10 branch.

I guess a commit that fixes C89 build needed here too (ask Sergey P.
where he meet a problem with it).

Maybe it is better to place the libyaml update first, before enabling
bundling by default: this way looks more safe.

Other than that I have no objection.

LGTM. No need to re-review with me after the changes suggested above:
just carefully test it.

WBR, Alexander Turenko.


More information about the Tarantool-patches mailing list