[Tarantool-patches] [PATCH v2] vinyl: restart read iterator in case of rolled back WAL

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sat Jun 20 19:33:19 MSK 2020


>> Talking of the tests, I tried running multiple instances of the new
>> test:
>>
>>     python test-run.py gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un gh-3395-read-prepared-un
>>
>> And it fails sometimes. So it is flaky. Better fix it before push.
> 
> I've added a tiny fix:
> 
> diff --git a/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua b/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua
> index 10b70dd85..70136ddff 100644
> --- a/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua
> +++ b/test/vinyl/gh-3395-read-prepared-uncommitted.test.lua
> @@ -55,9 +55,7 @@ function read_prepared_with_delay(is_tx_faster_than_wal)
>          errinj.set("ERRINJ_RELAY_FASTER_THAN_TX", true)
>      end
>      errinj.set("ERRINJ_WAL_DELAY", false)
> -    if not is_tx_faster_than_wal then
> -        fiber.sleep(0.1)
> -    end
> +    fiber.sleep(0.1)
>      errinj.set("ERRINJ_VY_READ_PAGE_DELAY", false)
>      local res = c:get()
>      errinj.set("ERRINJ_WAL_WRITE", false)
> 
> 
> Could you please check if it still fails on your machine?

Now it works.


More information about the Tarantool-patches mailing list