[Tarantool-patches] [PATCH 3/8] txn: add TXN_WAIT_ACK flag

Leonid Vasiliev lvasiliev at tarantool.org
Fri Jun 19 02:12:59 MSK 2020


Hi! Thank you for the patch.


>   	stailq_foreach_entry(stmt, &txn->stmts, next) {
>   		if (stmt->has_triggers) {
>   			txn_init_triggers(txn);
>   			rlist_splice(&txn->on_commit, &stmt->on_commit);
>   		}
> +		is_sync = is_sync || stmt->space->def->opts.is_sync;

Seems like
"... || (stmt->space != NULL && stmt->space->def->opts.is_sync);"
can be moved here from "replication: make sync transactions wait quorum".

LGTM.


More information about the Tarantool-patches mailing list