[Tarantool-patches] [PATCH v2] memtx: fix tuples references on concurrent replaces

[Aleksandr Lyapunov]

Great, lgtm now

On 6/12/20 1:18 AM, Ilya Kosarev wrote:
> Since 527b02a2ee6a9a205d8e2c8f38bbb84edf0d6557 (memtx: add yields
> during index build) memtx_build_on_replace was introduced to handle
> concurrent updates. The problem here was that the tuples being handled
> with this trigger did not get reference counter promotion, leading to a
> number of wrong behavior cases. Now this problem is solved.
> This problem was found through primary index altering with updates in
> background fiber. Corresponding test is introduced.
>
> Closes #4973
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4973-segfaults-on-alter
> Issue: https://github.com/tarantool/tarantool/issues/4973
>
> @ChangeLog:
>   * Fix concurrent replaces on index building. Tuples are now referenced
>   on all needed execution paths.
>
>   Changes in v2:
> - stmt->new_tuple NULL case considered
> - respectively extended test