[Tarantool-patches] [PATCH 0/2] ASAN build

[Vladislav Shpilevoy]

On 16/06/2020 01:04, Alexander Turenko wrote:
> On Tue, Jun 16, 2020 at 12:21:13AM +0200, Vladislav Shpilevoy wrote:
>> Hi!
>>
>> On 15/06/2020 16:01, Alexander Turenko wrote:
>>> LGTM except broken coverage reporting:
>>>
>>> https://travis-ci.org/github/tarantool/tarantool/jobs/698246927
>>>
>>> It looks quite similar to
>>> https://github.com/tarantool/tarantool/commit/415c05868f95b45a56904d5aa581358aced05efe
>>>
>>> Maybe we should add '-o ${CMAKE_BINARY_DIR}/src/box/sql/parse.c' to
>>> lemon call to write absolute path in #line directives, which may help to
>>> avoid ambiguity.
>>
>> Thanks for noticing and for the proposed fix. I did this:
>>
>> -    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c ${SQL_SRC_DIR}/parse.y
>> +    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c -o${SQL_BIN_DIR}/parse ${SQL_SRC_DIR}/parse.y
> 
> Nit: I would use `-o${SQL_BIN_DIR}/parse.c` with explicit `.c` suffix.
> The effect is the same, but the command line looks more natural. Up to
> you.

Changed to parse.c.