[Tarantool-patches] [PATCH 0/2] ASAN build

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Jun 16 01:21:13 MSK 2020


Hi!

On 15/06/2020 16:01, Alexander Turenko wrote:
> LGTM except broken coverage reporting:
> 
> https://travis-ci.org/github/tarantool/tarantool/jobs/698246927
> 
> It looks quite similar to
> https://github.com/tarantool/tarantool/commit/415c05868f95b45a56904d5aa581358aced05efe
> 
> Maybe we should add '-o ${CMAKE_BINARY_DIR}/src/box/sql/parse.c' to
> lemon call to write absolute path in #line directives, which may help to
> avoid ambiguity.

Thanks for noticing and for the proposed fix. I did this:

-    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c ${SQL_SRC_DIR}/parse.y
+    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c -o${SQL_BIN_DIR}/parse ${SQL_SRC_DIR}/parse.y

Now parse.c contains absolute paths in #line directives. But I couldn't
wait if it helped - travis is awfully slow. Lets see if it helped tomorrow,
when the job will be finally done.


More information about the Tarantool-patches mailing list