[Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by default

[Alexander Turenko]

LGTM.

Pushed to master and 2.4. Several minor comments below.

WBR, Alexander Turenko.

On Wed, May 27, 2020 at 01:15:35PM +0300, Olga Arkhangelskaia wrote:
> Hi Igor!
> 
> Thanks for the review:
> 
> I have changed the order and left a small comment, so the diff looks like:
> 
> -if(CMAKE_VERSION VERSION_LESS 3.11)
> -    if(POLICY CMP0037)
> +if (POLICY CMP0037)
> +    # https://cmake.org/cmake/help/v3.11/release/3.11.html#other-changes
> +    # cmake below 3.11 reserves name test. Use old politics.

Nit: AFAIU, 'politics' and 'policy' are not synonyms: the former is more
about goverment actions (see [1]).

> +    if (CMAKE_VERSION VERSION_LESS 3.11)
>          cmake_policy(SET CMP0037 OLD)
> -    endif(POLICY CMP0037)
> -else()
> -    if(POLICY CMP0037)
> +    else()
> +        # Starting from cmake 3.11 name test reserved in special cases and
> can
> +        # be used as target name.

Nit: We usually fit our comments within 66 symbols (except URIs).

>          cmake_policy(SET CMP0037 NEW)
> -    endif(POLICY CMP0037)
> +    endif()
>  endif()

I don't see those changes on the branch [2]. Anyway, I applied those
changes manually and changes according to the comments above, pushed it
to master and 2.4 and removed the branch.

[1]: https://dictionary.cambridge.org/us/grammar/british-grammar/politics-political-politician-or-policy
[2]: OKriw/gh-3587-CMP0037-OLD-cmake-deprecation-warning-full-ci