[Tarantool-patches] [PATCH 0/2] ASAN build

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Jun 14 19:24:29 MSK 2020


The build was broken because sql static library couldn't find some
box symbols, when UB sanitizer was enabled.

Appeared, that the whole sql library was broken, because there was
a cyclic dependency between box and sql libraries.

The patch merged sql and box libraries.

After their merge appeared that some UB sanitations 'woken up' and
started failing, about nullability attributes and usage of NULL
pointers. All of them were false-positive so the second patch
disabled them.

After this patchset the build works, but the tests don't pass
because of this:
https://github.com/tarantool/tarantool/issues/5078.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5067-asan-build
Issue: https://github.com/tarantool/tarantool/issues/5067
Issue: https://github.com/tarantool/tarantool/issues/4609

Vladislav Shpilevoy (2):
  sql: don't build sql as a separate library
  cmake: split UB sanitations into separate flags.

 cmake/compiler.cmake       |  44 +++++++++++++--
 src/CMakeLists.txt         |   2 +-
 src/box/CMakeLists.txt     | 101 ++++++++++++++++++++++++++++++++--
 src/box/sql/CMakeLists.txt | 109 -------------------------------------
 4 files changed, 138 insertions(+), 118 deletions(-)
 delete mode 100644 src/box/sql/CMakeLists.txt

-- 
2.21.1 (Apple Git-122.3)



More information about the Tarantool-patches mailing list