[Tarantool-patches] [PATCH] memtx: fix tuples references on concurrent replaces

Aleksandr Lyapunov alyapunov at tarantool.org
Thu Jun 11 16:44:50 MSK 2020


Thanks for the patch! See my comment below.

On 6/7/20 5:08 PM, Ilya Kosarev wrote:
> +	/*
> +	 * All tuples stored in a memtx space must be
> +	 * referenced by the primary index.
> +	 */
> +	if (state->index->def->iid == 0)
> +		tuple_ref(stmt->new_tuple);
I'm afraid that stmt->new_tuple can be NULL here.
Could you please create another test for this issue when some tuples are 
deleted during snapshot. I bet it will crash.


More information about the Tarantool-patches mailing list