[Tarantool-patches] [PATCH] static build: fix build on ubuntu

Alexander Turenko alexander.turenko at tarantool.org
Tue Jun 9 19:33:30 MSK 2020


LGTM.

I didn't verify it manually, but the change itself looks reasonable and
CI pass (except flaky tests and known Mac OS X problem on Travis-CI).

Sergey, can you look into the proposed change too?

Alexander (Tikhonov), we added a CI job to verify such things within
[1]. Can you, please, look how it appears that the job didn't catch the
problem?

> Issue: https://github.com/tarantool/tarantool/issues/5024
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5024-static-build-ubuntu

Please, answer with a changelog entry for future release notes. We track
user-visible behaviour changes this way: bugfixes and features. When
there is a fix for some build target or configuration, we mention it
too.

It is just free form description of changes for a user to be placed on
the [releases page][2]. We highlight with @ChangeLog 'tag' to bring a
mainterner attention.

Since it is the regression, it would be good to mention, when the
problem appears (`git describe bad_commit` output), in the future
release notes.

For future patches: add it to a cover letter or under `---` for a
signleton patchset (but do not add to a commit message).

[1]: https://github.com/tarantool/tarantool/issues/4551
[2]: https://github.com/tarantool/tarantool/releases

WBR, Alexander Turenko.


More information about the Tarantool-patches mailing list