[Tarantool-patches] [PATCH v2] Add option to update file with reference output

Sergey Bronnikov sergeyb at tarantool.org
Mon Jun 8 18:31:11 MSK 2020


Hi,

Alexander, I send a new version of patches with fixes after review.

On 12:19 Mon 08 Jun , Alexander Turenko wrote:
> Sergey, please squash fixup commits before sending a next version of a
> patchset to review.
> 
> Please, put flake8 configuration update first: so each commit will pass
> CI.

put it first on updated patchset

> The 'new' status disappears in the new patchset version. Can you look at
> this again? It looks as unintentional change.

Yeah, my bad. Fixed it.

> > -            elif not self.is_crash_reported and not self.is_equal_result:
> > +            elif (not self.is_crash_reported and not self.is_equal_result):
> 
> Please, avoid unneeded diffs.

reverted change

> WBR, Alexander Turenko.

-- 
sergeyb@


More information about the Tarantool-patches mailing list