[Tarantool-patches] [PATCH 2/3] lua/cfg: drop redundant variable

Oleg Babin olegrok at tarantool.org
Mon Jun 8 18:31:06 MSK 2020


Thanks for your patch. LGTM.

On 08/06/2020 13:44, Cyrill Gorcunov wrote:
> No need for variable v, we use module_cfg itself.
> 
> Part-of #689
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>   src/box/lua/load_cfg.lua | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua
> index 7a77b93f5..7dc40a47f 100644
> --- a/src/box/lua/load_cfg.lua
> +++ b/src/box/lua/load_cfg.lua
> @@ -494,7 +494,7 @@ local function apply_default_cfg(cfg, default_cfg, module_cfg)
>               apply_default_cfg(cfg[k], v)
>           end
>       end
> -    for k, v in pairs(module_cfg) do
> +    for k in pairs(module_cfg) do
>           if cfg[k] == nil then
>               cfg[k] = module_cfg[k].cfg_get(k)
>           end
> 


More information about the Tarantool-patches mailing list