[Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods

Oleg Babin olegrok at tarantool.org
Mon Jun 8 18:29:25 MSK 2020


Hi! Thanks for your patch. See 1 comment below.

On 08/06/2020 13:44, Cyrill Gorcunov wrote:
> The dynamic configuration of logging level and
> format now goes via log module. These functions
> are no longed needed.
> 
> Part-of #689
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>   src/box/lua/cfg.cc | 24 ------------------------
>   1 file changed, 24 deletions(-)
> 
> diff --git a/src/box/lua/cfg.cc b/src/box/lua/cfg.cc
> index ed56b0b5c..a5b15e527 100644
> --- a/src/box/lua/cfg.cc
> +++ b/src/box/lua/cfg.cc
> @@ -87,28 +87,6 @@ lbox_cfg_set_replication(struct lua_State *L)
>   	return 0;
>   }
>   
> -static int
> -lbox_cfg_set_log_level(struct lua_State *L)
> -{
> -	try {
> -		box_set_log_level();
> -	} catch (Exception *) {
> -		luaT_error(L);
> -	}
> -	return 0;
> -}
> -
> -static int
> -lbox_cfg_set_log_format(struct lua_State *L)
> -{
> -	try {
> -		box_set_log_format();
> -	} catch (Exception *) {
> -		luaT_error(L);
> -	}
> -	return 0;
> -}
> -

I assume that "box_set_log_level" and "box_set_log_format" should be 
removed as well.


More information about the Tarantool-patches mailing list