[Tarantool-patches] [PATCH 1/6] Add initial luacheck config
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Sat Jun 6 21:02:45 MSK 2020
Hi! Thanks for the patch!
On 04/06/2020 10:39, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
>
> config includes all files with Lua source code except:
Lets start sentences from capital letters.
> - third_party repositories
> - directories with diff-based tests
Seems like src/* is excluded. So nothing is checked, and the
commit message is wrong.
I see, that you turn on the checks in next commits, but then the
commit message should be changed.
> How-to check:
>
> $ luacheck --codes --config .luacheckrc .
>
> Part of #4681
>
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy at tarantool.org>
More information about the Tarantool-patches
mailing list