[Tarantool-patches] [PATCH 2/2] feedback: collect db engines and index features

[Ilya Konyukhov]

This patch adds basic db features to feedback report.
It collects info about what engine and which types of
indexes are setup by the user.

Here is how report may look like if all the features used:

```json
{
  "arch": "x64",
  "features": {
    "has_bitset_index": true,
    "has_jsonpath_index": true,
    "vinyl": true,
    "has_tree_index": true,
    "has_primary_index": true,
    "has_hash_index": true,
    "memtx": true,
    "has_temporary_spaces": true,
    "has_local_spaces": true,
    "has_rtree_index": true,
    "has_secondary_index": true,
    "has_functional_index": true
  },
  "server_id": "7c8490f7-61c5-4e12-a7ff-d9fed05ad8ac",
  "is_docker": false,
  "os": "OSX",
  "feedback_type": "version",
  "cluster_id": "1eb7d98e-3344-4f15-a439-c287464f09e7",
  "tarantool_version": "2.5.0-90-g27fbe6ecd",
  "feedback_version": 1
}
```

Part of #4943
---
 src/box/lua/feedback_daemon.lua       | 65 +++++++++++++++++++++++++++
 test/box-tap/feedback_daemon.test.lua | 42 ++++++++++++++++-
 2 files changed, 106 insertions(+), 1 deletion(-)

diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua
index 2ce49fb22..0fcd8ed87 100644
--- a/src/box/lua/feedback_daemon.lua
+++ b/src/box/lua/feedback_daemon.lua
@@ -41,6 +41,15 @@ local function detect_docker_environment()
     return true
 end
 
+local function is_system_space(sp)
+    local sp_id = sp.id
+    if box.schema.SYSTEM_ID_MIN <= sp_id and sp_id <= box.schema.SYSTEM_ID_MAX then
+        return true
+    end
+
+    return false
+end
+
 local function fill_in_base_info(feedback)
     if box.info.status ~= "running" then
         return nil, "not running"
@@ -56,9 +65,65 @@ local function fill_in_platform_info(feedback)
     feedback.is_docker = detect_docker_environment()
 end
 
+local function fill_in_space_indices(feedback, sp)
+    if not sp.index[0] then return end
+
+    feedback.features.has_primary_index = true
+    local idx_count = 0
+    for _, idx in pairs(sp.index) do
+        for _, part in pairs(idx.parts) do
+            if part.path ~= nil then
+                feedback.features.has_jsonpath_index = true
+                break
+            end
+        end
+        if idx.func ~= nil then
+            feedback.features.has_functional_index = true
+        end
+        if idx.type == 'TREE' then
+            feedback.features.has_tree_index = true
+        elseif idx.type == 'HASH' then
+            feedback.features.has_hash_index = true
+        elseif idx.type == 'RTREE' then
+            feedback.features.has_rtree_index = true
+        elseif idx.type == 'BITSET' then
+            feedback.features.has_bitset_index = true
+        end
+        idx_count = idx_count + 1
+    end
+
+    if idx_count > 1 then
+        feedback.features.has_secondary_index = true
+    end
+end
+
+local function fill_in_features(feedback)
+    feedback.features = feedback.features or {}
+
+    local is_memtx, is_vinyl, is_temporary, is_local
+    for _, sp in pairs(box.space) do
+        local is_system = is_system_space(sp)
+        if not is_system then
+            if sp.engine == 'vinyl' then is_vinyl = true end
+            if sp.engine == 'memtx' then
+                if sp.temporary ~= nil then is_temporary = true end
+                is_memtx = true
+            end
+            if sp.is_local ~= nil then is_local = true end
+            fill_in_space_indices(feedback, sp)
+        end
+    end
+
+    feedback.features.has_temporary_spaces = is_temporary
+    feedback.features.has_local_spaces = is_local
+    feedback.features.memtx = is_memtx
+    feedback.features.vinyl = is_vinyl
+end
+
 local function fill_in_feedback(feedback)
     fill_in_base_info(feedback)
     fill_in_platform_info(feedback)
+    fill_in_features(feedback)
 
     return feedback
 end
diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
index c36b2a694..e382af8e8 100755
--- a/test/box-tap/feedback_daemon.test.lua
+++ b/test/box-tap/feedback_daemon.test.lua
@@ -67,7 +67,7 @@ if not ok then
     os.exit(0)
 end
 
-test:plan(11)
+test:plan(16)
 
 local function check(message)
     while feedback_count < 1 do
@@ -113,6 +113,46 @@ check("feedback after start")
 daemon.send_test()
 check("feedback after feedback send_test")
 
+local feedback_json = json.decode(feedback_save)
+test:is(type(feedback_json.features), 'table', 'features field is present')
+test:isnil(next(feedback_json.features), 'features are empty at the moment')
+
+box.schema.create_space('features_vinyl', {engine = 'vinyl'})
+box.schema.create_space('features_memtx', {engine = 'memtx', is_local = true, temporary = true})
+box.space.features_memtx:create_index('vinyl_pk', {type = 'tree'})
+box.space.features_memtx:create_index('memtx_pk', {type = 'hash'})
+box.space.features_memtx:create_index('memtx_bitset', {type = 'bitset'})
+box.space.features_memtx:create_index('memtx_rtree', {type = 'rtree', parts = {3, 'array'}})
+box.space.features_memtx:create_index('memtx_jpath',
+        {parts = {{field=4, type='str', path='data.name'}}})
+box.schema.func.create('features_func', {
+    body = "function(tuple) return {string.sub(tuple[2],1,1)} end",
+    is_deterministic = true,
+    is_sandboxed = true})
+box.space.features_memtx:create_index('j',
+        {parts={{field = 1, type = 'number'}},func = 'features_func'})
+
+check('old feedback received')
+feedback_reset()
+check('feedback with db features received')
+
+feedback_json = json.decode(feedback_save)
+test:test('features', function(t)
+    t:plan(12)
+    t:ok(feedback_json.features.memtx, 'memtx engine usage gathered')
+    t:ok(feedback_json.features.vinyl, 'vinyl engine usage gathered')
+    t:ok(feedback_json.features.has_temporary_spaces, 'temporary space usage gathered')
+    t:ok(feedback_json.features.has_local_spaces, 'local space usage gathered')
+    t:ok(feedback_json.features.has_primary_index, 'primary index gathered')
+    t:ok(feedback_json.features.has_secondary_index, 'secondary index gathered')
+    t:ok(feedback_json.features.has_tree_index, 'tree index gathered')
+    t:ok(feedback_json.features.has_hash_index, 'hash index gathered')
+    t:ok(feedback_json.features.has_rtree_index, 'rtree index gathered')
+    t:ok(feedback_json.features.has_bitset_index, 'bitset index gathered')
+    t:ok(feedback_json.features.has_jsonpath_index, 'jsonpath index gathered')
+    t:ok(feedback_json.features.has_functional_index, 'functional index gathered')
+end)
+
 daemon.stop()
 
 box.feedback.save("feedback.json")
-- 
2.24.3 (Apple Git-128)