[Tarantool-patches] [PATCH 2/3] box: always wait box loading in box.execute()

Igor Munkin imun at tarantool.org
Thu Jun 4 02:12:59 MSK 2020


Sasha,

Thanks for the patch! It LGTM, but is "blocked" since it strongly
depends on the previous one.

On 13.05.20, Alexander Turenko wrote:
> <box_load_and_execute> checks whether box is configured with appropriate
> locking and configures it when necessary. However it is not so for
> <lbox_execute>. We should replace the former with the latter only when
> box is fully loaded.
> 
> Follow-up #4231
> ---
>  src/box/lua/load_cfg.lua                      | 20 ++++++++++++---
>  .../gh-4231-box-execute-locking.test.lua      | 25 ++++++++++++++++++-
>  test/box-tap/suite.cfg                        |  6 +++++
>  test/box-tap/suite.ini                        |  1 +
>  4 files changed, 48 insertions(+), 4 deletions(-)
>  create mode 100644 test/box-tap/suite.cfg
> 

<snipped>

> -- 
> 2.25.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list