[Tarantool-patches] [PATCH v1 1/2] Correct error message at pwd.lua

Alexander V. Tikhonov avtikhon at tarantool.org
Wed Jun 3 14:37:49 MSK 2020


Hi Alexander, thanks for the review, I've changed it as you suggested.

On Mon, Jun 01, 2020 at 01:47:56PM +0300, Alexander Turenko wrote:
> On Sun, May 31, 2020 at 08:12:42AM +0300, Alexander V. Tikhonov wrote:
> > During investigation of the issues found that error message had
> > not user friendly format:
> >  local pwgr_errstr = "get%s failed [errno %d]: %s"
> > produced:
> >  [001] LuajitError: builtin/pwd.lua:101: getgetgrall failed [errno 2]: No such file or directory
> > while it had to be:
> >  [001] LuajitError: builtin/pwd.lua:101: get getgrall failed [errno 2]: No such file or directory
> > Fixed the error message.
> 
> My bad, looks as regression from
> 6c5d3f060459c943bbba8394e7f1f91f79efb5a6 ('lua: pwd: split data fetch
> from deserialization').
> 
> LGTM, but, please, make it just 'getgrall failed [errno 2]: No such file
> or directory', without leading 'get'.
> 
> WBR, Alexander Turenko.


More information about the Tarantool-patches mailing list