[Tarantool-patches] [PATCH v8 09/12] test: logger -- use log module directly

Oleg Babin olegrok at tarantool.org
Wed Jun 3 10:02:11 MSK 2020


Hi! Thanks for your patch see one comment below.

On 03/06/2020 01:18, Cyrill Gorcunov wrote:

> +-- Test that changes in log module are propagated
> +-- back to the box module correctly
> +box.cfg{
> +    log=filename,
> +    log_format='json',
> +    log_level=6,
> +    memtx_memory=107374182,
> +}
> +test:is(box.cfg.log_format, 'json', 'box in json format')
> +test:is(box.cfg.log_level, 6, 'box level 6')

It's quite strange. You change box.cfg options and check that box.cfg 
options are changed. I suppose you should check log.cfg options here.

Anyway if you cover that box.cfg change propagates to log.cfg you should 
test that log.cfg changes propagate to box.cfg as well.



More information about the Tarantool-patches mailing list