[Tarantool-patches] [PATCH 0/3] Merger's NULL defererence

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Jun 3 01:47:27 MSK 2020


Hi! Thanks for the patchset!

I would also ask Igor for a review. Because the patchset does
some manipulations with luaL names, and attempts to optimize
Lua-C code.

On 01/06/2020 20:10, Alexander Turenko wrote:
> The first patch is a bunch of renames: I dropped luaL prefix from
> several functions to highlight the contract: they can be called from
> usual C code, w/o any requirements to pass or to place a Lua state
> somewhere.
> 
> The second patch just fixes NULL pointer dereference that occurs due to
> the wrong assumption: I did think that fiber().storage.lua.stack is
> always exists and non-NULL.
> 
> The third commit is the optimization: it allows to don't create a new
> Lua state in merger when possible.
> 
> https://github.com/tarantool/tarantool/issues/4954
> Totktonada/gh-4954-fix-merger-segfault-full-ci

Do we need a changelog? Bugfixes are visible behaviour change.


More information about the Tarantool-patches mailing list