[Tarantool-patches] [PATCH v2] lua: remove excess Lua call from table encoding

[Sergey Ostanevich]

Hi!

Thanks for the patch!

Still I would like to see some tests - perhaps with errinj to emulate
OOM or some other case that trigger the 'excess protected frame' need.
So that after your changes it still passes.

Regards,
Sergos


On 02 июн 18:01, Sergey Kaplun wrote:
> On 02.06.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Nice. Almost forgot: please also provide a ChangeLog entry.
> 
> @Changelog:
>  * Refactor Lua table encoding: removed excess Lua function object and
> protected Lua frame creation to improve `msgpack.encode()` performance.
> 
> > 
> > On 02.06.20, Sergey Kaplun wrote:
> > > Hi! Thanks for the review!
> > > 
> > 
> > <snipped>
> > 
> > > 
> > > -- 
> > > Best regards,
> > > Sergey Kaplun
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun