[Tarantool-patches] [PATCH v7 05/11] lua/log: do not allow to set json for boot logger

Oleg Babin olegrok at tarantool.org
Tue Jun 2 10:51:21 MSK 2020


Hi. Thanks for your patch see one comment.

On 02/06/2020 01:25, Cyrill Gorcunov wrote:
> pcall(log, {log_format = 'json'})

It seems to be incorrect.

```
tarantool> pcall(log, {log_format = 'json'})
---
- false
- attempt to call a table value
...
```

And it should be
```
tarantool> pcall(log.log_format, 'json')
---
- false
- 'builtin/log.lua:228: log_format: json can''t be used with syslog or 
boot-time logger'
...
```

Also please check error message. Smth like:
```
err:find('log_format: json can\'t be used with syslog or boot%-time 
logger') ~= nil
```


More information about the Tarantool-patches mailing list