[Tarantool-patches] [PATCH 2/6] sql: remove mem_apply_type() from OP_MakeRecord

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Mon Jun 1 20:03:57 MSK 2020


Thanks for the patch!

> diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> index 2a941025c..fc41ee0d6 100644
> --- a/src/box/sql/vdbe.c
> +++ b/src/box/sql/vdbe.c
> @@ -2902,7 +2902,6 @@ case OP_CheckType: {
>   * into ephemeral space. Thus, sort of memory optimization can be performed.
>   */

P4 should be removed from the comment too.

>  case OP_MakeRecord: {
> -	Mem *pRec;             /* The new record */
>  	Mem *pData0;           /* First field to be combined into the record */
>  	Mem MAYBE_UNUSED *pLast;  /* Last field of the record */
>  	int nField;            /* Number of fields in the record */


More information about the Tarantool-patches mailing list