[Tarantool-patches] [PATCH V2] socket: fix error while closing socket.tcp_server

Ilya Kosarev i.kosarev at tarantool.org
Mon Jun 1 18:11:42 MSK 2020


LGTM

  
>Пятница, 29 мая 2020, 15:41 +03:00 от Alexander Turenko <alexander.turenko at tarantool.org>:
> 
>On Tue, May 19, 2020 at 11:05:25PM +0300, Leonid Vasiliev wrote:
>> The tcp server starts in a separate fiber.
>> When server's socket is closed from another fiber,
>> an exception will be thrown in server's loop from
>> check_socket function.
>> A "socket is close" check has been added at server's
>> fiber and now server's fiber terminates correctly.
>>
>> Fixes: #4087
>> ---
>>  https://github.com/tarantool/tarantool/issues/4087
>>  https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4087-fix-socket-stuff
>>
>> @Changelog fix error while closing socket.tcp_server socket(gh-4087)
>>
>> For a "socket is close" check, fd < 0 is used instead of an additional flag.
>LGTM. 
 
 
--
Ilya Kosarev
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20200601/9f1a0fab/attachment.html>


More information about the Tarantool-patches mailing list