[Tarantool-patches] [PATCH v6 05/25] Fix luacheck warnings in src/lua/

[Sergey Bronnikov]

On 12:43 Mon 01 Jun , Igor Munkin wrote:
> Sergey,
> 
> The root cause of these warnings is not related to globals per se, but
> to theirs modification. So you need to add suppressions for [122] and
> [142] codes similar to ones you added for extra/dist/tarantoolctl.in.

Done and pushed to remote branch.

> On 30.05.20, Sergey Bronnikov wrote:
> > On 22:13 Fri 29 May , Igor Munkin wrote:
> > > One more comment: if LuaJIT std is set, suppressions for os and package
> > > globals can be omitted.
> > 
> > with suggested changes new warnings appears:
> > 
> > Checking src/lua/init.lua                         4 warnings
> > 
> > src/lua/init.lua:83:1: (W122) setting read-only field exit of global os
> > src/lua/init.lua:225:1: (W142) setting undefined field search of global package
> > src/lua/init.lua:226:1: (W142) setting undefined field searchroot of global package
> > src/lua/init.lua:227:1: (W142) setting undefined field setsearchroot of global package
> > 
> > so I reverted back
> > 
> > > -- 
> > > Best regards,
> > > IM
> 
> -- 
> Best regards,
> IM