[Tarantool-patches] [PATCH v6 03/25] gitlab-ci: enable static analysis with luacheck

[Igor Munkin]

Sergey,

On 01.06.20, Sergey Bronnikov wrote:
> Igor,
> 
> thanks for review!
> 
> On 22:25 Fri 29 May , Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! It LGTM, except the one comment: I'm not a Gitlab
> > CI expert but since you introduced a separate make rule for luacheck, it
> > looks like you can use it also in CI. As a result of such change we have
> > a single place where luacheck command is mentioned excplicitly in our
> > project, that simplifies further maintenance.
> 
> You are right, it is a piece of duplicated code. But in a CI I don't use
> tarantool build infrastructure at all, because we don't need to build
> tarantool to check Lua code used in it. Let me know if you have an ideas
> how to share luacheck command line with CMakeLists.txt and GitLab CI
> config.

Yes, you don't need to build tarantool, just to configure it. But I
totally don't insist and leave this question for more competent CI
users.

> 

<snipped>

> 
> -- 
> sergeyb@

-- 
Best regards,
IM