[Tarantool-patches] [PATCH v1] gitlab-ci: restore lto testing on OSX

Kirill Yukhin kyukhin at tarantool.org
Tue Jul 28 18:42:12 MSK 2020


Hello,

On 28 июл 18:09, Alexander V. Tikhonov wrote:
> Found that after commit:
> 
>   7faa1abe2b2dedd3a5d2971ddd7c5b9ce55c30b2 "gitlab-ci: implement OSX 10.14 testing on mac mini"
> 
> the variable environment CMAKE_EXTRA_PARAMS, which turns on LTO flag
> on OSX compilation was mistakenly missed to be updated and LTO feature
> was disabled on OSX testing in real.
> 
> After it later commit:
> 
>   a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5 "lua/log: add ability to configure logging early"
> 
> added the missed LTO error, which was fixed at:
> 
>   625095d95c5d1962c02c124fcba098e527f017fd "lua/log: add missing exports"
> 
> Closes #5160

LGTM.
I've checked your patch into 1.10 2.4 2.5 and master.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list