[Tarantool-patches] [PATCH] lua/log: add missing exports

Alexander V. Tikhonov avtikhon at tarantool.org
Tue Jul 28 16:48:37 MSK 2020


Hi Cyrill, I've checked your patch and it fixed LTO build on OSX.
Please proceed with it, patch LGTM.

On Tue, Jul 28, 2020 at 04:27:42PM +0300, Cyrill Gorcunov wrote:
> When building with LTO non exported symbols might
> be discarded while we have implicit use in log.lua
> code.
> 
> Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
> 
> Fixes #5160
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>  src/exports.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/exports.h b/src/exports.h
> index fe3b31dba..7cf283e5b 100644
> --- a/src/exports.h
> +++ b/src/exports.h
> @@ -350,6 +350,8 @@ EXPORT(PMurHash32_Result)
>  EXPORT(port_destroy)
>  EXPORT(random_bytes)
>  EXPORT(_say)
> +EXPORT(say_logger_init)
> +EXPORT(say_logger_initialized)
>  EXPORT(say_logrotate)
>  EXPORT(say_set_log_format)
>  EXPORT(say_set_log_level)
> -- 
> 2.26.2
> 


More information about the Tarantool-patches mailing list