[Tarantool-patches] [PATCH v3 2/6] journal: bind asynchronous write completion to an entry

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

> diff --git a/src/box/journal.h b/src/box/journal.h
> index 9049a2ce0..759eea1da 100644
> --- a/src/box/journal.h
> +++ b/src/box/journal.h
> @@ -39,8 +39,11 @@
>  extern "C" {
>  #endif /* defined(__cplusplus) */
>  
> +struct journal_entry;

1. You removed this declaration in the previous commit. I guess you
don't need the latter now.

>  struct xrow_header;
>  
> +typedef void (*journal_write_async_cb_t)(struct journal_entry *entry);

2. Better replace _cb_t with _f. Or with just _t. Look at key_def.h and
xrow_update_field.h for examples.

> +
>  /**
>   * An entry for an abstract journal.