[Tarantool-patches] [PATCH 1/1] txn: remove TXN_IS_DONE check from txn_commit()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Jul 22 01:43:35 MSK 2020


On 21.07.2020 10:45, Cyrill Gorcunov wrote:
> On Tue, Jul 21, 2020 at 01:21:17AM +0300, Cyrill Gorcunov wrote:
>> On Mon, Jul 20, 2020 at 10:24:01PM +0200, Vladislav Shpilevoy wrote:
>>> Still need somebody to take a look at this. It would
>>> help to make txn_commit more straightforward.
>>>
>>> Sergey Os.? Cyrill G. maybe?
>>
>> The idea looks reasonable. Could you please rebase the patch
>> on current master once time permit? This flag comes from the
>> series where I've been reworking journal engine hunting the
>> nil dereference in parallel applier code and after discussion
>> with KostyaO we choose to make helper functions which would
>> trigger error in case if async write is called from bootstrap
>> and recover code.
>>
>> Still removing code is always a good thing :-) I'll try to
>> rebase it myself tomorrow if you wont beat me on it today.
> 
> I've updated the patch locally. Vlad, lets postpone this
> particular patch -- I'm about to change journal code again
> for qsync reason and will grab your patch on top. Then will
> send it in the batch. Sounds ok?

I rebased the patch and added one more commit to make it work. See
the new email thread.


More information about the Tarantool-patches mailing list