[Tarantool-patches] [PATCH 1/1] txn_limbo: use fiber_clock() instead of fiber_time()
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Tue Jul 21 23:26:21 MSK 2020
Pushed to master.
On 21.07.2020 00:09, Cyrill Gorcunov wrote:
> On Mon, Jul 20, 2020 at 11:11:39PM +0200, Vladislav Shpilevoy wrote:
>> box.ctl.clear_synchro_queue() used fiber_time()
>> instead of fiber_clock() to wait for a timeout. This is wrong,
>> fiber_time() is realtime, not suitable for relative timeouts.
>>
>> For that purpose always should be used monotonic clock. The patch
>> fixes that.
>>
>> Follow up #4849
>
> (side note: monotonic clocks do not account acpi-deep-sleep state,
> ie when cpu is in sleep state it wont be accounted, but i think
> it is impossible scenario for us. so put this note just for
> reference).
>
> Good catch!
Thanks for Leonid, he found the problem.
> Acked-by: Cyrill Gorcunov <gorcunov at gmail.com>
Sorry, I forgot to add Acked-By, realized this after push.
More information about the Tarantool-patches
mailing list