[Tarantool-patches] [PATCH 1/1] box: fixed box.info:memory()

Igor Munkin imun at tarantool.org
Fri Jul 17 00:04:43 MSK 2020


Olya,

Thanks for the fixes! I checked the upstream. The patch LGTM except the
tiny nit.


Sasha, please proceed with the patch.

On 16.07.20, Olga Arkhangelskaia wrote:

<snipped>

> When box.info:memory is called, it has box.info table as a first

Typo: s/a first/the first/.

> argument (seehttps://www.lua.org/manual/5.1/manual.html#2.8). While
> printing the table, lbox_info_memory_call adds box.info.memory's fields
> to the box.info table. To avoid this effect and return just
> box.info.memory we put an empty table on the Lua stack at the beginning
> of the lbox_info_memory_call function. Instead adding fields to box.info
> table lbox_info_memory_call fills that empty table.

<snipped>

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list