[Tarantool-patches] [PATCH 16/16] tx: use new tx manager in	memtx
    Vladislav Shpilevoy 
    v.shpilevoy at tarantool.org
       
    Thu Jul 16 01:09:34 MSK 2020
    
    
  
>> +static int
>>> +memtx_engine_prepare(struct engine *engine, struct txn *txn)
>>> +{
>>> +    (void)engine;
>>> +    struct txn_stmt *stmt;
>>> +    stailq_foreach_entry(stmt, &txn->stmts, next) {
>>> +        if (stmt->add_story != NULL || stmt->del_story != NULL)
>> 1. Seems like it is worth moving this check into a static inline
>> function in the txn.h header. You use it a lot.
> It's a virtual method, it can't be inlined..
I am talking about the check. Not about the memtx_engine_prepare().
    stmt->add_story != NULL || stmt->del_story != NULL
This line can be moved into a static inline function in txn.h.
    
    
More information about the Tarantool-patches
mailing list