[Tarantool-patches] [PATCH] engine: validate key in space_before_replace

Kirill Yukhin kyukhin at tarantool.org
Tue Jul 14 14:03:21 MSK 2020


Hello,

On 03 июл 16:32, Ilya Kosarev wrote:
> Since 9fba29abb4e05babb9b23b4413bd8083f0fba933 (memtx: introduce tuple
> compare hint) index_get uses key_hint to get a comparison hint for the
> key. It requires key type to be validated. However in
> space_before_replace index_get was used without key validation on some
> execution paths. Now it is fixed and validation is being performed if
> needed. Corresponding test case is introduced.
> 
> Closes #5093
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5093-before_replace-key-validation
> Issue: https://github.com/tarantool/tarantool/issues/5093

LGTM.

I've checked your patch into 2.3, 2.4 and master.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list