[Tarantool-patches] [PATCH 6/6] Fix luacheck warnings in src/box/lua/

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Jul 14 01:59:11 MSK 2020


Thanks for the fixes!

I force pushed the following change:

====================
diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua
index 7256bd0a3..1d3c474d5 100644
--- a/src/box/lua/net_box.lua
+++ b/src/box/lua/net_box.lua
@@ -915,7 +915,7 @@ end
 -- Now it is necessary to have a strong ref to callback somewhere or
 -- it is GC-ed prematurely. We wrap stop() method, stashing the
 -- ref in an upvalue (stop() performance doesn't matter much.)
-local create_transport = function(host, port, user, password, callback, -- luacheck: ignore
+local create_transport = function(host, port, user, password, callback,
                                   connection, greeting)
     local weak_refs = setmetatable({callback = callback}, {__mode = 'v'})
     local function weak_callback(...)

====================

But what I don't understand is why this commit does not close 4681?
What is left?


More information about the Tarantool-patches mailing list